[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/17] s390x: Adjust GDB stub
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH 10/17] s390x: Adjust GDB stub |
Date: |
Fri, 25 Mar 2011 13:16:29 +0100 |
On 25.03.2011, at 13:07, Nathan Froyd wrote:
> On Thu, Mar 24, 2011 at 04:58:46PM +0100, Alexander Graf wrote:
>> We have successfully lazilized cc computation, so we need to manually
>> trigger its calculation when gdb wants to fetch it. We also changed the
>> variable name, so writing it writes into a different field now.
>
> Wouldn't you want to:
>
> a) change the variable name in the earlier commit and just do the
> manual triggering in this commit, so as not to break bisect; or
> b) combine this change with the previous lazification?
I mostly did the variable name change so I can easily track all users of cc and
adjust them accordingly.
The nice position we're in with S/390 is that nobody is building it currently.
And even if they were, it would just break as compilation has been broken for
quite a while now (ivshmem). So I basically assume that the target is only
enabled for real bisecting as of the last patch which enables its configuration
in the default target list.
Alex
- [Qemu-devel] [PATCH 02/17] virtio: use generic name when possible, (continued)
- [Qemu-devel] [PATCH 02/17] virtio: use generic name when possible, Alexander Graf, 2011/03/24
- [Qemu-devel] [PATCH 11/17] s390x: virtio machine storage keys, Alexander Graf, 2011/03/24
- [Qemu-devel] [PATCH 15/17] s390x: Adjust internal kvm code, Alexander Graf, 2011/03/24
- [Qemu-devel] [PATCH 01/17] Only build ivshmem when CONFIG_PCI && CONFIG_KVM, Alexander Graf, 2011/03/24
- [Qemu-devel] [PATCH 07/17] linux-user: define a couple of syscalls for non-uid16 targets, Alexander Graf, 2011/03/24
- [Qemu-devel] [PATCH 17/17] s390x: build s390x by default, Alexander Graf, 2011/03/24
- [Qemu-devel] [PATCH 10/17] s390x: Adjust GDB stub, Alexander Graf, 2011/03/24
- [Qemu-devel] [PATCH 03/17] s390x: Enable disassembler for s390x, Alexander Graf, 2011/03/24
- [Qemu-devel] [PATCH 12/17] s390x: Prepare cpu.h for emulation, Alexander Graf, 2011/03/24
- [Qemu-devel] [PATCH 13/17] s390x: helper functions for system emulation, Alexander Graf, 2011/03/24
- [Qemu-devel] [PATCH 06/17] s390x: s390x-linux-user support, Alexander Graf, 2011/03/24
- [Qemu-devel] [PATCH 14/17] s390x: Implement opcode helpers, Alexander Graf, 2011/03/24