Re: [Qemu-devel] [PATCH] ide/atapi: fix set but unused

[Paolo Bonzini]

On 04/28/2011 10:07 AM, Alon Levy wrote:
> Signed-off-by: Alon Levy<address@hidden>
> ---
>   hw/ide/atapi.c |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
> index 690a0ab..81fa01b 100644
> --- a/hw/ide/atapi.c
> +++ b/hw/ide/atapi.c
> @@ -1080,12 +1080,14 @@ static const struct {
>
>   void ide_atapi_cmd(IDEState *s)
>   {
> +#ifdef DEBUG_IDE_ATAPI
>       const uint8_t *packet;
> +#endif
>       uint8_t *buf;
>
> -    packet = s->io_buffer;
>       buf = s->io_buffer;
>   #ifdef DEBUG_IDE_ATAPI
> +    packet = s->io_buffer;
>       {
>           int i;
>           printf("ATAPI limit=0x%x packet:", s->lcyl | (s->hcyl<<  8));

ACK

... but why don't we allow interspersing declarations and statements? 
There are already so many C99 and GCC extensions in use in QEMU.

Paolo