Re: [Qemu-devel] [PATCH 01/27] Clean up PowerPC SLB handling code

[David Gibson]

On Thu, May 19, 2011 at 10:25:04AM +0200, Andreas Färber wrote:
> QEMU HEAD still uses a 32-bit binary for both 32-bit and
> 64-bit. That one uses mtsrin so will need the compatibility, it
> seemed affected, too.
> 
> OpenBIOS SVN HEAD (blob) uses slb* as linked to. We're in the
> preparation of 1.1 and I need to test it before we can update the
> QEMU binary. ;)
> 
> Sorry for top-posting, Android sucks.

So, my theory was half right.  It was a problem with 64-bit mtsr
emulation, but it wasn't that I just removed that code with the SLB
cleanup.  The code was still there and *almost* right.  I was off by
one in one shift, causing the storage key bits to end up in the wrong
place in the SLB entry.  I'll send out the patch right after I've sent
this mail.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson