Re: [Qemu-devel] [PATCH 01/13] spice: Use cpu_register_physical_memory_log for dirty log enabling

[Gerd Hoffmann]

  Hi,

> Note: The addtional vga_dirty_log_start for the primary interface looked
> stray. qxl_write_config enabled logging for all interfaces anyway.

No.  qxl_write_config is hooked for the primary only.

>       case QXL_RAM_RANGE_INDEX:
> -        cpu_register_physical_memory(addr, size, qxl->vga.vram_offset | 
> IO_MEM_RAM);
> +        cpu_register_physical_memory_log(addr, size,
> +                                         qxl->vga.vram_offset | IO_MEM_RAM,
> +                                         0, true);

if (qxl->id == 0) {
    cpu_register_physical_memory_log(...)
} else {
    cpu_register_physical_memory()
}

Only the primary is vga compatible and thus needs dirty logging.

cheers,
  Gerd