Re: [Qemu-devel] [PATCHv3] qxl: abort on panic instead of exit

[Gerd Hoffmann]

On 06/29/11 13:57, Alon Levy wrote:
> ---
>   hw/qxl.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/qxl.h b/hw/qxl.h
> index 7df594e..bf875a0 100644
> --- a/hw/qxl.h
> +++ b/hw/qxl.h
> @@ -89,7 +89,7 @@ typedef struct PCIQXLDevice {
>
>   #define PANIC_ON(x) if ((x)) {                         \
>       printf("%s: PANIC %s failed\n", __FUNCTION__, #x); \
> -    exit(-1);                                          \
> +    abort();                                          \
>   }

Not urgent, but I think this should change.  A bunch of the PANIC_ON 
checks are guest-triggerable.  Long-term I want invalid requests from 
the guest just be ignored by default.  Keeping an option to do something 
else is fine (log a message, abort, write out guest dump, whatever), I 
see that this can be quite useful for guest driver debugging.

cheers,
  Gerd