Re: [Qemu-devel] [PATCH v6 04/12] VMDK: separate vmdk_open by format version

[Fam Zheng]

>
> bdrv_pread only ever returns 0 for success or -errno for errors. So you
> can simplify the code like this:
>
> ret = bdrv_pread(...);
> if (ret < 0) {
>    goto fail_l1;
> }
>
> You have the same pattern in other places, too.
>

I think bdrv_pead do return the read bytes, did you mean bdrv_read here? :)

-- 
Best regards!
Fam Zheng