qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from l

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp
Date: Sun, 03 Jul 2011 16:09:01 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Mnenhy/0.8.3 Thunderbird/3.1.10 
On 07/02/2011 11:43 AM, Jan Kiszka wrote:

  static const char *pch;
+static char *saved_key;
  static jmp_buf expr_env;

  #define MD_TLONG 0
@@ -4254,8 +4255,11 @@ static const mon_cmd_t *monitor_parse_command(Monitor 
*mon,
                      }
                      typestr++;
                  }
-                if (get_expr(mon,&val,&p))
+                saved_key = key;
+                if (get_expr(mon,&val,&p)) {
+                    key = saved_key;
                      goto fail;
+                }


Please make saved_key a volatile local instead.

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]