Re: [Qemu-devel] [RFC v3 31/56] ac97: convert to memory API

[Anthony Liguori]

On 07/10/2011 03:33 PM, malc wrote:
> On Sun, 10 Jul 2011, Avi Kivity wrote:
>
> > fixes BAR sizing as well.
>
> I find this patch disgusting, the read and write handlers in particular.

Shouldn't it be possible to do something like:

typedef struct OldMemoryRegionOps {
    MemoryRegionOps parent_ops;
    CPUReadMemoryFunc *readfn[3];
    CPUWriteMemoryFunc *writefn[3];
    void *opaque;
} OldMemoryRegionOps;

That should allow old-style implementations to be converted without 
introducing trampoline functions everywhere.

Regards,

Anthony Liguori

> [..snip..]