[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions |
Date: |
Wed, 2 Nov 2011 13:01:31 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Nov 01, 2011 at 03:24:28PM -0500, Anthony Liguori wrote:
> >Hi,
> >
> >the patch looks reasonable. I only suggest a formal change:
> >
> >There are lots of unnecessary type casts in several of your patches.
> >I marked them here, but they should be removed anywhere.
>
> Agreed. However, I'm going to apply this series as I'd like to get
> it in for the freeze. But David, please follow up with a patch to
> remove the unnecessary type casts.
>
> Regards,
>
> Anthony Liguori
Further, eepro100 now needs to be fixed to use pci_dma_write/read
instead of stXXX/ldXXX, as address passed in apparently can be
unaligned.
--
MST
Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions,
Michael S. Tsirkin <=