[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 06/11] stdio_pclose: return -errno on error
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [RFC PATCH 06/11] stdio_pclose: return -errno on error |
Date: |
Wed, 2 Nov 2011 10:32:12 -0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Nov 01, 2011 at 05:20:25PM -0200, Eduardo Habkost wrote:
> This is what qemu_fclose() expects.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> savevm.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/savevm.c b/savevm.c
> index 3c746a6..63dd719 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -233,8 +233,9 @@ static int stdio_get_buffer(void *opaque, uint8_t *buf,
> int64_t pos, int size)
> static int stdio_pclose(void *opaque)
> {
> QEMUFileStdio *s = opaque;
> - int ret;
> - ret = pclose(s->stdio_file);
> + int ret = 0;
> + if (pclose(s->stdio_file) == -1)
> + ret = -errno;
> g_free(s);
> return ret;
Self-NACK. We have to return the pclose() return value here, because
exec_close() needs it.
Thanks to Paolo for spotting it.
--
Eduardo
- [Qemu-devel] [RFC PATCH 07/11] stdio_fclose: return -errno on errors, (continued)
- [Qemu-devel] [RFC PATCH 07/11] stdio_fclose: return -errno on errors, Eduardo Habkost, 2011/11/01
- [Qemu-devel] [RFC PATCH 03/11] exec_close(): accept any negative value as qemu_fclose() error, Eduardo Habkost, 2011/11/01
- [Qemu-devel] [RFC PATCH 09/11] fd_close(): check for close() errors too, Eduardo Habkost, 2011/11/01
- [Qemu-devel] [RFC PATCH 08/11] exec_close(): return -errno on errors, Eduardo Habkost, 2011/11/01
- [Qemu-devel] [RFC PATCH 05/11] qemu_fclose: return last_error if set, Eduardo Habkost, 2011/11/01
[Qemu-devel] [RFC PATCH 06/11] stdio_pclose: return -errno on error, Eduardo Habkost, 2011/11/01
- Re: [Qemu-devel] [RFC PATCH 06/11] stdio_pclose: return -errno on error,
Eduardo Habkost <=
Re: [Qemu-devel] [RFC PATCH 00/11] qemu_fclose() error handling fixes, Juan Quintela, 2011/11/02
Re: [Qemu-devel] [RFC PATCH 00/11] qemu_fclose() error handling fixes, Michael Roth, 2011/11/04