[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id |
Date: |
Mon, 07 Nov 2011 16:17:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 |
On 11/07/2011 01:00 PM, Gerd Hoffmann wrote:
> This patch removes the code lines which set the subsystem id for the
> emulated ac97 card to 8086:0000. Due to the device id being zero the
> subsystem id isn't vaild anyway. With the patch applied the sound card
> gets the default qemu subsystem id (1af4:1100) instead.
>
> Cc: Takashi Iwai <address@hidden>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> hw/ac97.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/hw/ac97.c b/hw/ac97.c
> index 6800af4..b43e435 100644
> --- a/hw/ac97.c
> +++ b/hw/ac97.c
> @@ -1305,12 +1305,6 @@ static int ac97_initfn (PCIDevice *dev)
> c[PCI_BASE_ADDRESS_0 + 6] = 0x00;
> c[PCI_BASE_ADDRESS_0 + 7] = 0x00;
>
> - c[PCI_SUBSYSTEM_VENDOR_ID] = 0x86; /* svid subsystem vendor id rwo
> */
> - c[PCI_SUBSYSTEM_VENDOR_ID + 1] = 0x80;
> -
> - c[PCI_SUBSYSTEM_ID] = 0x00; /* sid subsystem id rwo */
> - c[PCI_SUBSYSTEM_ID + 1] = 0x00;
> -
This a guest ABI change. Do we want -M support for it?
--
error compiling committee.c: too many arguments to function
- [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id, Gerd Hoffmann, 2011/11/07
- Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id,
Avi Kivity <=
- Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id, Gerd Hoffmann, 2011/11/07
- Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id, Anthony Liguori, 2011/11/07
- Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id, Avi Kivity, 2011/11/07
- Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id, Anthony Liguori, 2011/11/07
- Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id, Avi Kivity, 2011/11/07
- Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id, Anthony Liguori, 2011/11/07
- Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id, Avi Kivity, 2011/11/07
- Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id, Gerd Hoffmann, 2011/11/07
- Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id, Avi Kivity, 2011/11/07