[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 8/8] hw/lan9118.c: Add missing 'break' to fix buffer
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 8/8] hw/lan9118.c: Add missing 'break' to fix buffer overrun |
Date: |
Thu, 10 Nov 2011 12:36:44 +0000 |
From: Peter Maydell <address@hidden>
Add a missing 'break' statement to fix a buffer overrun when
executing the EEPROM write-all command. Spotted by Coverity
(see bug 887883).
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/lan9118.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/lan9118.c b/hw/lan9118.c
index 634b88e..f8149e6 100644
--- a/hw/lan9118.c
+++ b/hw/lan9118.c
@@ -863,6 +863,7 @@ static void lan9118_eeprom_cmd(lan9118_state *s, int cmd,
int addr)
} else {
DPRINTF("EEPROM Write All (ignored)\n");
}
+ break;
case 5: /* ERASE */
if (s->eeprom_writable) {
s->eeprom[addr] = 0xff;
--
1.7.7.1
- [Qemu-devel] [PULL 0/8] Trivial patches for 8 to 10 November 2011, Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 6/8] x86/cpuid: Plug memory leak in cpudef_setfield(), Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 7/8] x86/cpuid: Fix crash on -cpu "", Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 1/8] qemu-tech.texi: Update default code cache size, Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 3/8] qdev: Fix crash on -device '?=x', Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 4/8] ui/vnc: Convert sasl.mechlist to g_malloc() & friends, Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 8/8] hw/lan9118.c: Add missing 'break' to fix buffer overrun,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 2/8] configure: Show --cpu option on the help list, Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 5/8] x86/cpuid: Convert remaining strdup() to g_strdup(), Stefan Hajnoczi, 2011/11/10
- Re: [Qemu-devel] [PULL 0/8] Trivial patches for 8 to 10 November 2011, Anthony Liguori, 2011/11/10