[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 13/13] s390x: initialize virtio dev region
From: |
Alexander Graf |
Subject: |
[Qemu-devel] [PATCH 13/13] s390x: initialize virtio dev region |
Date: |
Sun, 13 Nov 2011 16:33:54 +0100 |
When running the s390x virtio machine we can potentially use uninitialized
memory for the virtio device backing ram. That can lead to weird breakge.
So let's better initialize it to 0 properly.
Reported-by: Andreas Färber <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>
---
v1 -> v2:
- use target_phys_addr_t
---
hw/s390-virtio.c | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/hw/s390-virtio.c b/hw/s390-virtio.c
index 37945d5..61b67e8 100644
--- a/hw/s390-virtio.c
+++ b/hw/s390-virtio.c
@@ -165,6 +165,9 @@ static void s390_init(ram_addr_t my_ram_size,
ram_addr_t initrd_size = 0;
int shift = 0;
uint8_t *storage_keys;
+ void *virtio_region;
+ target_phys_addr_t virtio_region_len;
+ target_phys_addr_t virtio_region_start;
int i;
/* s390x ram size detection needs a 16bit multiplier + an increment. So
@@ -184,6 +187,15 @@ static void s390_init(ram_addr_t my_ram_size,
memory_region_init_ram(ram, NULL, "s390.ram", my_ram_size);
memory_region_add_subregion(sysmem, 0, ram);
+ /* clear virtio region */
+ virtio_region_len = my_ram_size - ram_size;
+ virtio_region_start = ram_size;
+ virtio_region = cpu_physical_memory_map(virtio_region_start,
+ &virtio_region_len, true);
+ memset(virtio_region, 0, virtio_region_len);
+ cpu_physical_memory_unmap(virtio_region, virtio_region_len, 1,
+ virtio_region_len);
+
/* allocate storage keys */
storage_keys = g_malloc0(my_ram_size / TARGET_PAGE_SIZE);
--
1.6.0.2
- [Qemu-devel] [PULL 00/13] s390 patch queue 2011-11-13 1.0, Alexander Graf, 2011/11/13
- [Qemu-devel] [PATCH 04/13] s390x: update R and C bits in storage key, Alexander Graf, 2011/11/13
- [Qemu-devel] [PATCH 13/13] s390x: initialize virtio dev region,
Alexander Graf <=
- [Qemu-devel] [PATCH 06/13] s390x: implement SIGP restart and shutdown, Alexander Graf, 2011/11/13
- [Qemu-devel] [PATCH 12/13] tcg: Use TCGReg for standard tcg-target entry points., Alexander Graf, 2011/11/13
- [Qemu-devel] [PATCH 09/13] s390: Fix cpu shutdown for KVM, Alexander Graf, 2011/11/13
- [Qemu-devel] [PATCH 02/13] s390x: add ldeb instruction, Alexander Graf, 2011/11/13
- [Qemu-devel] [PATCH 03/13] s390x: make ipte 31-bit aware, Alexander Graf, 2011/11/13
- [Qemu-devel] [PATCH 01/13] [S390] Add hotplug support, Alexander Graf, 2011/11/13
- [Qemu-devel] [PATCH 11/13] tcg: Standardize on TCGReg as the enum for hard registers, Alexander Graf, 2011/11/13
- [Qemu-devel] [PATCH 07/13] s390: fix reset hypercall to reset the status, Alexander Graf, 2011/11/13