[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1.1 6/6] block: avoid useless checks on acb->bh
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 1.1 6/6] block: avoid useless checks on acb->bh |
Date: |
Mon, 14 Nov 2011 17:50:54 +0100 |
Coverity is confused by this "if" and reports leaks on acb->bh.
The bottom half is always deleted before releasing the AIOCB,
in either bdrv_aio_cancel_em or bdrv_aio_bh_cb.
Signed-off-by: Paolo Bonzini <address@hidden>
---
block.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/block.c b/block.c
index 05b0e2c..e847738 100644
--- a/block.c
+++ b/block.c
@@ -2490,9 +2490,7 @@ static BlockDriverAIOCB
*bdrv_aio_rw_vector(BlockDriverState *bs,
acb->is_write = is_write;
acb->qiov = qiov;
acb->bounce = qemu_blockalign(bs, qiov->size);
-
- if (!acb->bh)
- acb->bh = qemu_bh_new(bdrv_aio_bh_cb, acb);
+ acb->bh = qemu_bh_new(bdrv_aio_bh_cb, acb);
if (is_write) {
qemu_iovec_to_buffer(acb->qiov, acb->bounce);
--
1.7.7.1
- [Qemu-devel] [PATCH 1.1 0/6] block: drop useless checks for NULL, Paolo Bonzini, 2011/11/14
- [Qemu-devel] [PATCH 1.1 1/6] block: bdrv_aio_* do not return NULL, Paolo Bonzini, 2011/11/14
- [Qemu-devel] [PATCH 1.1 3/6] block: qemu_aio_get does not return NULL, Paolo Bonzini, 2011/11/14
- [Qemu-devel] [PATCH 1.1 2/6] block: simplify failure handling for bdrv_aio_multiwrite, Paolo Bonzini, 2011/11/14
- [Qemu-devel] [PATCH 1.1 4/6] dma: the passed io_func does not return NULL, Paolo Bonzini, 2011/11/14
- [Qemu-devel] [PATCH 1.1 5/6] block: dma_bdrv_* does not return NULL, Paolo Bonzini, 2011/11/14
- [Qemu-devel] [PATCH 1.1 6/6] block: avoid useless checks on acb->bh,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 1.1 v2] block: bdrv_aio_* do not return NULL, Paolo Bonzini, 2011/11/30
- Re: [Qemu-devel] [PATCH 1.1 0/6] block: drop useless checks for NULL, Paolo Bonzini, 2011/11/30