[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] Makefile: fix qga dependencies
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] Makefile: fix qga dependencies |
Date: |
Thu, 17 Nov 2011 13:22:45 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 |
Am 17.11.2011 10:31, schrieb Paolo Bonzini:
> On 11/16/2011 10:58 PM, Michael S. Tsirkin wrote:
>> .c files include .h files, so .o depends on .h,
>> and the linked result depends on .o.
>> We got it wrong for qga rules, fix it up.
>
> Another possible option is to make the "all" target depend on
> GENERATED_HEADERS and GENERATED_SOURCES, like
>
> all: $(GENERATED_HEADERS) $(GENERATED_SOURCES)
> @$(MAKE) build-all
>
> and drop the dependency everywhere else.
Please don't. `make qemu-img`, for example, should work, too. That
bypasses the "all" target IIUC.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg