[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/8] qcow2: Fix order of refcount updates in qco
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 6/8] qcow2: Fix order of refcount updates in qcow2_snapshot_goto |
Date: |
Fri, 18 Nov 2011 17:38:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 |
Am 18.11.2011 17:28, schrieb Stefan Hajnoczi:
> On Thu, Nov 17, 2011 at 3:13 PM, Kevin Wolf <address@hidden> wrote:
>> - /* FIXME This is too late! */
>> - ret = qcow2_update_snapshot_refcount(bs, s->l1_table_offset,
>> s->l1_size, 1);
>> + if (ret < 0) {
>> + goto fail;
>> + }
>> +
>> + g_free(sn_l1_table);
>
> Prevent double-free if qcow2_update_snapshot_refcount() fails below:
>
> sn_l1_table = NULL;
Thanks, good catch. Fixed this locally.
Kevin
- [Qemu-devel] [PATCH 0/8] qcow2: Fix error paths for internal snapshots, Kevin Wolf, 2011/11/17
- [Qemu-devel] [PATCH 1/8] qcow2: Return real error code in qcow2_read_snapshots, Kevin Wolf, 2011/11/17
- [Qemu-devel] [PATCH 4/8] qcow2: Rework qcow2_snapshot_create error handling, Kevin Wolf, 2011/11/17
- [Qemu-devel] [PATCH 3/8] qcow2: Cleanups and memleak fix in qcow2_snapshot_create, Kevin Wolf, 2011/11/17
- [Qemu-devel] [PATCH 7/8] qcow2: Fix order in qcow2_snapshot_delete, Kevin Wolf, 2011/11/17
- [Qemu-devel] [PATCH 6/8] qcow2: Fix order of refcount updates in qcow2_snapshot_goto, Kevin Wolf, 2011/11/17
- [Qemu-devel] [PATCH 2/8] qcow2: Return real error code in qcow2_write_snapshots, Kevin Wolf, 2011/11/17
- [Qemu-devel] [PATCH 8/8] qcow2: Fix error path in qcow2_snapshot_load_tmp, Kevin Wolf, 2011/11/17
- [Qemu-devel] [PATCH 5/8] qcow2: Return real error in qcow2_snapshot_goto, Kevin Wolf, 2011/11/17
- Re: [Qemu-devel] [PATCH 0/8] qcow2: Fix error paths for internal snapshots, Stefan Hajnoczi, 2011/11/18