[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/9] qcow2: Fix error paths for internal snap
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/9] qcow2: Fix error paths for internal snapshots |
Date: |
Mon, 21 Nov 2011 16:58:39 +0000 |
On Fri, Nov 18, 2011 at 6:28 PM, Kevin Wolf <address@hidden> wrote:
> Kevin Wolf (9):
> qcow2: Return real error code in qcow2_read_snapshots
> qcow2: Return real error code in qcow2_write_snapshots
> qcow2: Update snapshot table information at once
> qcow2: Cleanups and memleak fix in qcow2_snapshot_create
> qcow2: Rework qcow2_snapshot_create error handling
> qcow2: Return real error in qcow2_snapshot_goto
> qcow2: Fix order of refcount updates in qcow2_snapshot_goto
> qcow2: Fix order in qcow2_snapshot_delete
> qcow2: Fix error path in qcow2_snapshot_load_tmp
>
> block/qcow2-refcount.c | 7 +-
> block/qcow2-snapshot.c | 330
> +++++++++++++++++++++++++++++++++++-------------
> block/qcow2.c | 5 +-
> 3 files changed, 248 insertions(+), 94 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
I left a comment asking about bdrv_flush(bs->file) versus explicitly
flushing the qcow2 cache, but it's a wider question that later patches
could address, if necessary.
- [Qemu-devel] [PATCH v2 5/9] qcow2: Rework qcow2_snapshot_create error handling, (continued)
- [Qemu-devel] [PATCH v2 4/9] qcow2: Cleanups and memleak fix in qcow2_snapshot_create, Kevin Wolf, 2011/11/18
- [Qemu-devel] [PATCH v2 2/9] qcow2: Return real error code in qcow2_write_snapshots, Kevin Wolf, 2011/11/18
- [Qemu-devel] [PATCH v2 8/9] qcow2: Fix order in qcow2_snapshot_delete, Kevin Wolf, 2011/11/18
- [Qemu-devel] [PATCH v2 7/9] qcow2: Fix order of refcount updates in qcow2_snapshot_goto, Kevin Wolf, 2011/11/18
- [Qemu-devel] [PATCH v2 9/9] qcow2: Fix error path in qcow2_snapshot_load_tmp, Kevin Wolf, 2011/11/18
- [Qemu-devel] [PATCH v2 6/9] qcow2: Return real error in qcow2_snapshot_goto, Kevin Wolf, 2011/11/18
- Re: [Qemu-devel] [PATCH v2 0/9] qcow2: Fix error paths for internal snapshots,
Stefan Hajnoczi <=