[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/6] x86/cpuid: Tighten parsing of tsc_freq=FREQ
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 4/6] x86/cpuid: Tighten parsing of tsc_freq=FREQ |
Date: |
Tue, 22 Nov 2011 09:46:04 +0100 |
cpu_x86_find_by_name() uses strtosz_suffix_unit(), but screws up the
error checking. It detects some failures, but not all. Undetected
failures result in a zero tsc_khz value (error value -1 divided by
1000), which means "no tsc_freq set".
To reproduce, try "-cpu qemu64,tsc_freq=9999999T".
strtosz_suffix_unit() fails, because the value overflows int64_t,
Signed-off-by: Markus Armbruster <address@hidden>
---
target-i386/cpuid.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
index 21e5896..56c7671 100644
--- a/target-i386/cpuid.c
+++ b/target-i386/cpuid.c
@@ -692,7 +692,7 @@ static int cpu_x86_find_by_name(x86_def_t *x86_cpu_def,
const char *cpu_model)
tsc_freq = strtosz_suffix_unit(val, &err,
STRTOSZ_DEFSUFFIX_B, 1000);
- if (!*val || *err) {
+ if (tsc_freq < 0 || *err) {
fprintf(stderr, "bad numerical value %s\n", val);
goto error;
}
--
1.7.6.4
- [Qemu-devel] [PATCH 0/6] Fix strtosz users, clean up its implementation, Markus Armbruster, 2011/11/22
- [Qemu-devel] [PATCH 5/6] qemu-img: Tighten parsing of size arguments, Markus Armbruster, 2011/11/22
- [Qemu-devel] [PATCH 2/6] vl: Tighten parsing of -numa's parameter mem, Markus Armbruster, 2011/11/22
- [Qemu-devel] [PATCH 1/6] cutils: Drop broken support for zero strtosz default_suffix, Markus Armbruster, 2011/11/22
- [Qemu-devel] [PATCH 6/6] cutils: Make strtosz & friends leave follow set to callers, Markus Armbruster, 2011/11/22
- [Qemu-devel] [PATCH 3/6] vl: Tighten parsing of -m argument, Markus Armbruster, 2011/11/22
- [Qemu-devel] [PATCH 4/6] x86/cpuid: Tighten parsing of tsc_freq=FREQ,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH 0/6] Fix strtosz users, clean up its implementation, Anthony Liguori, 2011/11/28