[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support |
Date: |
Thu, 24 Nov 2011 20:07:50 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111105 Thunderbird/8.0 |
Am 23.11.2011 01:51, schrieb Peter Chubb:
>>>>>> "Peter" == Peter Chubb <address@hidden> writes:
>
>
> Peter> All comments received so far have been addressed --- I've added
> Peter> a macro, `scream' that gives at most 10 lines of output for OS
> Peter> error reporting.
>
> Except I noticed a thinko in the macro. The decrement should be
> inside the guard, thus:
>
> #define scream(fmt, args...) \
> do { \
> static int printable = 10;\
> if (printable) { \
> printable--;\
> fprintf(stderr, fmt, ##args); \
> } \
> } while (0)
Another issue:
scream("black");
scream("black");
scream("black");
scream("black");
scream("black");
scream("black");
scream("black");
scream("black");
scream("black");
scream("black");
scream("red");
To show us "red", in addition to the integer count a duplicate of the
string contents would need to be stored and compared to the newly
formatted string.
If we want to do this, it should go into a central file so that it can
be reused and centrally maintained.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH V2 2/4] imx.31 and KZM board support: Timer support, (continued)
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Peter Chubb, 2011/11/21
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Peter Maydell, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Andreas Färber, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Peter Maydell, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Andreas Färber, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Peter Maydell, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support, Peter Chubb, 2011/11/22
- Re: [Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support,
Andreas Färber <=
- Re: [Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support, Peter Chubb, 2011/11/26
- Re: [Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support, Peter Maydell, 2011/11/26
Re: [Qemu-devel] [PATCH] imx.31 and KZM board support, Juan Quintela, 2011/11/22