[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 10/16] qapi: Convert balloon
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 10/16] qapi: Convert balloon |
Date: |
Mon, 28 Nov 2011 16:11:19 -0200 |
Note that the command being dropped uses the deprecated MONITOR_CMD_ASYNC
API, but the new command is a regular synchronous command. There shouldn't
be visible differences though, as MONITOR_CMD_ASYNC is internal only.
Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>
---
balloon.c | 28 ++++++++--------------------
balloon.h | 3 ---
hmp-commands.hx | 4 +---
hmp.c | 12 ++++++++++++
hmp.h | 1 +
qapi-schema.json | 20 ++++++++++++++++++++
qmp-commands.hx | 6 +-----
7 files changed, 43 insertions(+), 31 deletions(-)
diff --git a/balloon.c b/balloon.c
index e1cd5fa..0166744 100644
--- a/balloon.c
+++ b/balloon.c
@@ -100,31 +100,19 @@ BalloonInfo *qmp_query_balloon(Error **errp)
return info;
}
-/**
- * do_balloon(): Request VM to change its memory allocation
- */
-int do_balloon(Monitor *mon, const QDict *params,
- MonitorCompletion cb, void *opaque)
+void qmp_balloon(int64_t value, Error **errp)
{
- int64_t target;
- int ret;
-
if (kvm_enabled() && !kvm_has_sync_mmu()) {
- qerror_report(QERR_KVM_MISSING_CAP, "synchronous MMU", "balloon");
- return -1;
+ error_set(errp, QERR_KVM_MISSING_CAP, "synchronous MMU", "balloon");
+ return;
}
- target = qdict_get_int(params, "value");
- if (target <= 0) {
+ if (value <= 0) {
qerror_report(QERR_INVALID_PARAMETER_VALUE, "target", "a size");
- return -1;
+ return;
}
- ret = qemu_balloon(target);
- if (ret == 0) {
- qerror_report(QERR_DEVICE_NOT_ACTIVE, "balloon");
- return -1;
+
+ if (qemu_balloon(value) == 0) {
+ error_set(errp, QERR_DEVICE_NOT_ACTIVE, "balloon");
}
-
- cb(opaque, NULL);
- return 0;
}
diff --git a/balloon.h b/balloon.h
index b36abea..b60fd5d 100644
--- a/balloon.h
+++ b/balloon.h
@@ -24,7 +24,4 @@ int qemu_add_balloon_handler(QEMUBalloonEvent *event_func,
QEMUBalloonStatus *stat_func, void *opaque);
void qemu_remove_balloon_handler(void *opaque);
-int do_balloon(Monitor *mon, const QDict *params,
- MonitorCompletion cb, void *opaque);
-
#endif
diff --git a/hmp-commands.hx b/hmp-commands.hx
index a054b9a..0badaac 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1021,9 +1021,7 @@ ETEXI
.args_type = "value:M",
.params = "target",
.help = "request VM to change its memory allocation (in MB)",
- .user_print = monitor_user_noop,
- .mhandler.cmd_async = do_balloon,
- .flags = MONITOR_CMD_ASYNC,
+ .mhandler.cmd = hmp_balloon,
},
STEXI
diff --git a/hmp.c b/hmp.c
index 0306a97..f9b3400 100644
--- a/hmp.c
+++ b/hmp.c
@@ -611,3 +611,15 @@ void hmp_block_passwd(Monitor *mon, const QDict *qdict)
qmp_block_passwd(device, password, &errp);
hmp_handle_error(mon, &errp);
}
+
+void hmp_balloon(Monitor *mon, const QDict *qdict)
+{
+ int64_t value = qdict_get_int(qdict, "value");
+ Error *errp = NULL;
+
+ qmp_balloon(value, &errp);
+ if (error_is_set(&errp)) {
+ monitor_printf(mon, "balloon: %s\n", error_get_pretty(errp));
+ error_free(errp);
+ }
+}
diff --git a/hmp.h b/hmp.h
index d6aa232..b0984ac 100644
--- a/hmp.h
+++ b/hmp.h
@@ -43,5 +43,6 @@ void hmp_cont(Monitor *mon, const QDict *qdict);
void hmp_inject_nmi(Monitor *mon, const QDict *qdict);
void hmp_set_link(Monitor *mon, const QDict *qdict);
void hmp_block_passwd(Monitor *mon, const QDict *qdict);
+void hmp_balloon(Monitor *mon, const QDict *qdict);
#endif
diff --git a/qapi-schema.json b/qapi-schema.json
index 08c16a6..6b71c45 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1018,3 +1018,23 @@
# Since: 0.14.0
##
{ 'command': 'block_passwd', 'data': {'device': 'str', 'password': 'str'} }
+
+##
+# @balloon:
+#
+# Request the balloon driver to change its balloon size.
+#
+# @value: the target size of the balloon in bytes
+#
+# Returns: Nothing on success
+# If the balloon driver is enabled but not functional because the KVM
+# kernel module cannot support it, KvmMissingCap
+# If no balloon device is present, DeviceNotActive
+#
+# Notes: This command just issues a request to the guest. When it returns,
+# the balloon size may not have changed. A guest can change the balloon
+# size independent of this command.
+#
+# Since: 0.14.0
+##
+{ 'command': 'balloon', 'data': {'value': 'int'} }
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 5e7e5dd..cf18ccd 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -703,11 +703,7 @@ EQMP
{
.name = "balloon",
.args_type = "value:M",
- .params = "target",
- .help = "request VM to change its memory allocation (in MB)",
- .user_print = monitor_user_noop,
- .mhandler.cmd_async = do_balloon,
- .flags = MONITOR_CMD_ASYNC,
+ .mhandler.cmd_new = qmp_marshal_input_balloon,
},
SQMP
--
1.7.8.rc3.31.g017d1.dirty
- [Qemu-devel] [PATCH 1.1 v1 00/16]: QAPI conversions round 3, Luiz Capitulino, 2011/11/28
- [Qemu-devel] [PATCH 01/16] qapi: Complete system_powerdown conversion, Luiz Capitulino, 2011/11/28
- [Qemu-devel] [PATCH 04/16] qapi: Convert memsave, Luiz Capitulino, 2011/11/28
- [Qemu-devel] [PATCH 03/16] QError: Introduce QERR_IO_ERROR, Luiz Capitulino, 2011/11/28
- [Qemu-devel] [PATCH 10/16] qapi: Convert balloon,
Luiz Capitulino <=
- [Qemu-devel] [PATCH 14/16] qapi: Convert migrate_cancel, Luiz Capitulino, 2011/11/28
- [Qemu-devel] [PATCH 11/16] qapi: Convert block_resize, Luiz Capitulino, 2011/11/28
- [Qemu-devel] [PATCH 02/16] console: Drop unused prototypes, Luiz Capitulino, 2011/11/28
- [Qemu-devel] [PATCH 15/16] qapi: Convert migrate_set_downtime, Luiz Capitulino, 2011/11/28
- [Qemu-devel] [PATCH 12/16] qapi: Convert blockdev_snapshot_sync, Luiz Capitulino, 2011/11/28
- [Qemu-devel] [PATCH 16/16] qapi: Convert migrate_set_speed, Luiz Capitulino, 2011/11/28
- [Qemu-devel] [PATCH 09/16] qapi: Convert block_passwd, Luiz Capitulino, 2011/11/28
- [Qemu-devel] [PATCH 13/16] qapi: Convert human-monitor-command, Luiz Capitulino, 2011/11/28
- [Qemu-devel] [PATCH 06/16] qapi: Convert cont, Luiz Capitulino, 2011/11/28
- [Qemu-devel] [PATCH 05/16] qapi: Convert pmemsave, Luiz Capitulino, 2011/11/28