|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH] fix out of tree build |
Date: | Mon, 28 Nov 2011 12:45:13 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13 |
On 11/28/2011 12:34 PM, Stefan Weil wrote:
Am 22.11.2011 18:27, schrieb Stefano Stabellini:Signed-off-by: Stefano Stabellini <address@hidden> diff --git a/Makefile b/Makefile index 168093c..885065f 100644 --- a/Makefile +++ b/Makefile @@ -167,7 +167,7 @@ check-qjson: check-qjson.o $(qobject-obj-y) $(tools-obj-y) test-coroutine: test-coroutine.o qemu-timer-common.o async.o $(coroutine-obj-y) $(tools-obj-y) $(qapi-obj-y): $(GENERATED_HEADERS) -qapi-dir := qapi-generated +qapi-dir := $(SRC_PATH)/qapi-generated test-visitor.o test-qmp-commands.o qemu-ga$(EXESUF): QEMU_CFLAGS += -I $(qapi-dir) qemu-ga$(EXESUF): LIBS = $(LIBS_QGA)This patch was committed to latest QEMU and breaks in-tree and out-of-tree builds. Without it, both kinds of builds work in my standard Debian configuration.
The patch is obviously incorrect. I'm going to revert it since the commit message has no explanation of why it's fixing anything.
Regards, Anthony Liguori
Regards, Stefan Weil gcc output (extract): CC /home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.o /home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c: In function ‘qapi_free_GuestAgentInfoList’: /home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c:39: warning: implicit declaration of function ‘visit_type_GuestAgentInfoList’ /home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c:39: warning: nested extern declaration of ‘visit_type_GuestAgentInfoList’ /home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c: In function ‘qapi_free_GuestAgentInfo’: /home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c:54: warning: implicit declaration of function ‘visit_type_GuestAgentInfo’ /home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c:54: warning: nested extern declaration of ‘visit_type_GuestAgentInfo’ /home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c: In function ‘qapi_free_GuestFileReadList’: /home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c:69: warning: implicit declaration of function ‘visit_type_GuestFileReadList’
[Prev in Thread] | Current Thread | [Next in Thread] |