[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event |
Date: |
Fri, 17 Feb 2012 11:32:48 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 |
On 02/16/2012 03:10 PM, Luiz Capitulino wrote:
> We have two external entities: the guest and the mngt app. It seems to me that
> the guest is seeing each step at a time.
The guest is seeing each step separately, but that is managed by the
device model (which sends two separate error codes: a NOT READY for
opening the tray, and a UNIT ATTENTION for closing the tray and changing
medium) rather than by the monitor.
> Btw, wrt fixing the internal model, I could do it in a different series, But
> I don't
> know exactly how to. Maybe bdrv_dev_change_media_cb() should be broken into
> multiple operations...
change_media_cb is really a move_tray_cb and we could rename it.
Calling it twice from the change command should work.
Paolo
- [Qemu-devel] [PATCH v2 0/4]: QMP: add BLOCK_MEDIUM_EJECT event, Luiz Capitulino, 2012/02/15
- [Qemu-devel] [PATCH 2/4] block: bdrv_eject(): Make eject_flag a real bool, Luiz Capitulino, 2012/02/15
- [Qemu-devel] [PATCH 1/4] block: Rename bdrv_mon_event() & BlockMonEventAction, Luiz Capitulino, 2012/02/15
- [Qemu-devel] [PATCH 3/4] block: bdrv_eject(): Add tray_changed parameter, Luiz Capitulino, 2012/02/15
- [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event, Luiz Capitulino, 2012/02/15
- Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event, Markus Armbruster, 2012/02/16
- Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event, Luiz Capitulino, 2012/02/16
- Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event, Luiz Capitulino, 2012/02/16
- Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event, Kevin Wolf, 2012/02/16
- Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event, Luiz Capitulino, 2012/02/16
- Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event, Kevin Wolf, 2012/02/17
- Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event, Markus Armbruster, 2012/02/17
- Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event, Kevin Wolf, 2012/02/17
- Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event, Markus Armbruster, 2012/02/17
- Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event, Markus Armbruster, 2012/02/16
- Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event, Luiz Capitulino, 2012/02/16
- Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event, Kevin Wolf, 2012/02/17
- Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event, Paolo Bonzini, 2012/02/17
- Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event, Markus Armbruster, 2012/02/17
- Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event, Markus Armbruster, 2012/02/17