Re: [Qemu-devel] [PATCH v2 1/2] qxl: introduce QXLCookie

[Alon Levy]

On Fri, Feb 17, 2012 at 01:49:20PM +0100, Marc-André Lureau wrote:
> Hi
> 
> On Fri, Feb 17, 2012 at 9:44 AM, Alon Levy <address@hidden> wrote:
> > +/* called from spice server thread context only */
> > +static void interface_async_complete(QXLInstance *sin, uint64_t 
> > cookie_token)
> > +{
> > +    PCIQXLDevice *qxl = container_of(sin, PCIQXLDevice, ssd.qxl);
> > +    QXLCookie *cookie = (QXLCookie*)cookie_token;
> > +
> > +    switch (cookie->type) {
> 
> We still have spice_qxl_flush_surfaces_async(&qxl->ssd.qxl, 0);
> 
> So cookie might be NULL in this case.

Yeah, Marc Andre also noticed (exprimentally - you take the cake on the
review :).

> 
> -- 
> Marc-André Lureau