[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/5] ide: drop ide_tray_state_post_load()
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 4/5] ide: drop ide_tray_state_post_load() |
Date: |
Fri, 17 Feb 2012 17:21:43 -0200 |
This is used to sync the physical tray state after migration when
using CD-ROM passthrough. However, migrating when using passthrough
is broken anyway and shouldn't be supported...
So, drop this function as it causes a problem with the DEVICE_TRAY_MOVED
event, which is going to be introduced by the next commit.
Signed-off-by: Luiz Capitulino <address@hidden>
---
hw/ide/core.c | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 0856385..ce570a7 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -2077,15 +2077,6 @@ static bool ide_drive_pio_state_needed(void *opaque)
|| (s->bus->error_status & BM_STATUS_PIO_RETRY);
}
-static int ide_tray_state_post_load(void *opaque, int version_id)
-{
- IDEState *s = opaque;
-
- bdrv_eject(s->bs, s->tray_open);
- bdrv_lock_medium(s->bs, s->tray_locked);
- return 0;
-}
-
static bool ide_tray_state_needed(void *opaque)
{
IDEState *s = opaque;
@@ -2125,7 +2116,6 @@ static const VMStateDescription vmstate_ide_tray_state = {
.version_id = 1,
.minimum_version_id = 1,
.minimum_version_id_old = 1,
- .post_load = ide_tray_state_post_load,
.fields = (VMStateField[]) {
VMSTATE_BOOL(tray_open, IDEState),
VMSTATE_BOOL(tray_locked, IDEState),
--
1.7.9.111.gf3fb0.dirty
- [Qemu-devel] [PATCH v3 0/5]: QMP: add DEVICE_TRAY_MOVED event, Luiz Capitulino, 2012/02/17
- [Qemu-devel] [PATCH 1/5] block: Rename bdrv_mon_event() & BlockMonEventAction, Luiz Capitulino, 2012/02/17
- [Qemu-devel] [PATCH 2/5] block: bdrv_eject(): Make eject_flag a real bool, Luiz Capitulino, 2012/02/17
- [Qemu-devel] [PATCH 3/5] block: Don't call bdrv_eject() if the tray state didn't change, Luiz Capitulino, 2012/02/17
- [Qemu-devel] [PATCH 4/5] ide: drop ide_tray_state_post_load(),
Luiz Capitulino <=
- [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event, Luiz Capitulino, 2012/02/17
- Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event, Markus Armbruster, 2012/02/20
- Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event, Kevin Wolf, 2012/02/22
- Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event, Markus Armbruster, 2012/02/23
- Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event, Luiz Capitulino, 2012/02/23
- Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event, Markus Armbruster, 2012/02/23
- Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event, Anthony Liguori, 2012/02/24
- Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event, Luiz Capitulino, 2012/02/24
- Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event, Anthony Liguori, 2012/02/24