Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

[Peter Maydell]

On 20 February 2012 19:51, Andreas Färber <address@hidden> wrote:
> Am 20.02.2012 20:43, schrieb Peter Maydell:
>> I don't particularly care how we QOMify arm_boot (it's not exactly at
>> the top of my priority list demanding attention), I do care that (a)
>> we have a sensible user-facing interface [ie command line options] and
>> (b) vl.c can usefully just pass the information from those options
>> straight to the boot loader code.
>
> A QOM'ified arm_boot could get a "virtual" callback method to check the
> QemuOpts command line args. That way derived classes can decide what
> additional options to accept.
>
> An alternative would be to expect QOM properties of the same name as the
> command line parameters and fail if there isn't one of that name.

You'd also need vl.c to be able to say "find me the first boot loader
of any kind in the qom tree" so it could set the properties on the
right thing.

But really qomifying arm_boot doesn't excite me very much -- it
doesn't really get us anything useful in the way that qomifying
SysBus, for instance, does. So my preference is not to have to
tie device tree support to it.

-- PMM