Re: [Qemu-devel] [PATCH v2 0/3] qemu-iotests: add image streaming tests

[Kevin Wolf]

Am 29.02.2012 14:25, schrieb Stefan Hajnoczi:
> This series adds the image streaming test suite to qemu-iotests.  It covers 
> the
> 'block_stream', 'block_job_cancel', 'block_job_set_speed', and
> 'query-block-jobs' QMP interfaces.
> 
> Since these tests involve QMP it is no longer convenient to write them in 
> bash.
> Instead these tests are written in Python and make use of the existing
> QMP/qmp.py module.  In order to achieve this, it adds an iotests Python module
> that handles interaction with the qemu-iotests framework.
> 
> If you want to review using a top-down approach, I suggest reading this series
> backwards, starting from Patch 3 which introduces 030, the image streaming 
> test
> suite.
> 
> Or if you like the bottom-up approach:
> 
> * Patch 1 exports TEST_DIR from qemu-iotests so test executables can learn the
>   temporary directory path.
> 
> * Patch 2 adds the iotests.py module, which brings together qemu-iotests,
>   unittest, and QEMU in a way that is easy to consume in Python.
> 
> * Patch 3 adds 030, the image streaming test suite.
> 
> Tests pass successfully with both qcow2 and qed on qemu.git/master.
> 
> v2:
>  * Python 2.6 compatibility, use public unittest.TextTestRunner [Kevin]
> 
> Stefan Hajnoczi (3):
>   qemu-iotests: export TEST_DIR for non-bash tests
>   qemu-iotests: add iotests Python module
>   test: add image streaming tests
> 
>  tests/qemu-iotests/030           |  151 +++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/030.out       |    5 +
>  tests/qemu-iotests/common.config |    2 +
>  tests/qemu-iotests/group         |    1 +
>  tests/qemu-iotests/iotests.py    |  164 
> ++++++++++++++++++++++++++++++++++++++
>  5 files changed, 323 insertions(+), 0 deletions(-)
>  create mode 100755 tests/qemu-iotests/030
>  create mode 100644 tests/qemu-iotests/030.out
>  create mode 100644 tests/qemu-iotests/iotests.py

Thanks, applied to the block branch.

Kevin