Re: [Qemu-devel] [PATCH] configure: Virtfs doesn't require libcap.

[Anthony Liguori]

On 04/22/2012 05:16 AM, Kusanagi Kouichi wrote:
> Only proxy helper does.
>
> Signed-off-by: Kusanagi Kouichi<address@hidden>

This broke the build:

http://spunk.home.kraxel.org/bb/builders/ubuntu-default/builds/52

Since the improve seems to be purely cosmetic, I'm going to revert this change.

Regards,

Anthony Liguori

> ---
>   configure |    6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 2d62d12..c8e6fe4 100755
> --- a/configure
> +++ b/configure
> @@ -2860,9 +2860,11 @@ tools=
>   if test "$softmmu" = yes ; then
>     tools="qemu-img\$(EXESUF) qemu-io\$(EXESUF) $tools"
>     if test "$virtfs" != no ; then
> -      if test "$cap" = yes&&  test "$linux" = yes&&  test "$attr" = yes ; then
> +      if test "$linux" = yes&&  test "$attr" = yes ; then
>           virtfs=yes
> -         tools="$tools fsdev/virtfs-proxy-helper\$(EXESUF)"
> +         if test "$cap" = yes ; then
> +             tools="$tools fsdev/virtfs-proxy-helper\$(EXESUF)"
> +         fi
>         else
>           if test "$virtfs" = yes; then
>               feature_not_found "virtfs"