Re: [Qemu-devel] [PATCH 1/2] hmp: expr_unary(): check for overflow in strtoul()/strtoull()

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 04/27/2012 03:04 AM, Markus Armbruster wrote:
>> Luiz Capitulino <address@hidden> writes:
[...]
>> You silently interpret a string that doesn't parse as zero.
>
> No...
>
>>> +        if (n == ULONG_MAX && errno == ERANGE) {
>>> +            expr_error(mon, "number too large");
>>> +        }
>>>  #endif
>>>          if (pch == p) {
>>>              expr_error(mon, "invalid char in expression");
>
> that check was already present.

You mean I'm supposed to read patch context?