[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/8] linux-user: Fix undefined HOST_LONG_SIZE on
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 3/8] linux-user: Fix undefined HOST_LONG_SIZE on PPC hosts |
Date: |
Tue, 1 May 2012 20:11:43 +0100 |
On 1 May 2012 19:54, Alexander Graf <address@hidden> wrote:
>
> On 01.05.2012, at 20:32, Andreas Färber wrote:
>
>> Am 01.05.2012 10:58, schrieb Alexander Graf:
>>> On my PPC host, HOST_LONG_SIZE is not defined even after
>>> running configure. Use the normal C way of determining the
>>> long size instead.
>>>
>>> Signed-off-by: Alexander Graf <address@hidden>
>>> ---
>>> thunk.h | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/thunk.h b/thunk.h
>>> index 5be8f91..87025c3 100644
>>> --- a/thunk.h
>>> +++ b/thunk.h
>>> @@ -113,7 +113,7 @@ static inline int thunk_type_size(const argtype
>>> *type_ptr, int is_host)
>>> defined(HOST_PARISC) || defined(HOST_SPARC64)
>>> return 4;
>>> #elif defined(HOST_PPC)
>>> - return HOST_LONG_SIZE;
>>> + return sizeof(void *);
>>
>> malc has committed a different fix (TARGET_ABI_BITS / 8) - thanks for
>> fixing the build - but this PULL will now conflict.
>
> :(.
>
> Removed from my queue.
We need to put out a patch which converts commit b754e4fc1 to
the fix as reviewed on the mailing list, because b754e4fc1 is
incorrect: it is returning the size of a target type when it
should be returning the size of a host type.
-- PMM
[Qemu-devel] [PATCH 1/8] booke:Use MMU API for creating initial mapping for secondary cpus, Alexander Graf, 2012/05/01
[Qemu-devel] [PATCH 2/8] PPC: Fix up e500 cache size setting, Alexander Graf, 2012/05/01
[Qemu-devel] [PATCH 8/8] target-ppc: Some support for dumping TLB_EMB TLBs, Alexander Graf, 2012/05/01
[Qemu-devel] [PATCH 7/8] ppce500_spin: Replace assert by hw_error (fixes compiler warning), Alexander Graf, 2012/05/01
[Qemu-devel] [PATCH 5/8] pseries: Use the same interrupt swizzling for host bridges as p2p bridges, Alexander Graf, 2012/05/01
[Qemu-devel] [PATCH 6/8] pseries: Fix use of global CPU state, Alexander Graf, 2012/05/01
[Qemu-devel] [PATCH 4/8] pseries: Implement automatic PAPR VIO address allocation, Alexander Graf, 2012/05/01