[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 08/21] qdev: use object_property_print in info qtree
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 08/21] qdev: use object_property_print in info qtree |
Date: |
Wed, 2 May 2012 13:31:00 +0200 |
Otherwise, non-string properties without a legacy counterpart are missed.
Also fix error propagation in object_property_print itself.
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/qdev-monitor.c | 2 +-
qom/object.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
index 41b9e2c..eed781d 100644
--- a/hw/qdev-monitor.c
+++ b/hw/qdev-monitor.c
@@ -493,7 +493,7 @@ static void qdev_print_props(Monitor *mon, DeviceState
*dev, Property *props,
if (object_property_get_type(OBJECT(dev), legacy_name, NULL)) {
value = object_property_get_str(OBJECT(dev), legacy_name, &err);
} else {
- value = object_property_get_str(OBJECT(dev), props->name, &err);
+ value = object_property_print(OBJECT(dev), props->name, &err);
}
g_free(legacy_name);
diff --git a/qom/object.c b/qom/object.c
index 464fc8f..b4f6c1d 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -839,7 +839,7 @@ char *object_property_print(Object *obj, const char *name,
char *string;
mo = string_output_visitor_new();
- object_property_get(obj, string_output_get_visitor(mo), name, NULL);
+ object_property_get(obj, string_output_get_visitor(mo), name, errp);
string = string_output_get_string(mo);
string_output_visitor_cleanup(mo);
return string;
--
1.7.9.3
- Re: [Qemu-devel] [PATCH 06/21] qdev: push "type" property up to Object, (continued)
[Qemu-devel] [PATCH 05/21] qom: assert that public types have a non-NULL parent field, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 07/21] qdev: fix -device foo,?, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 08/21] qdev: use object_property_print in info qtree,
Paolo Bonzini <=
[Qemu-devel] [PATCH 10/21] qdev: do not propagate properties to subclasses, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 09/21] qdev: move bus properties to a separate global, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 13/21] qdev: clean up global properties, Paolo Bonzini, 2012/05/02