[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 5/6] hmp: expr_unary(): check for overflow in strtoul
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PULL 5/6] hmp: expr_unary(): check for overflow in strtoul()/strtoull() |
Date: |
Tue, 8 May 2012 14:50:17 -0300 |
It's not checked currently, so something like:
(qemu) balloon -100000000000001111114334234
(qemu)
Will just "work" (in this case the balloon command will get a random
value).
Fix it by checking if strtoul()/strtoull() overflowed.
Signed-off-by: Luiz Capitulino <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
monitor.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/monitor.c b/monitor.c
index 8946a10..bf60984 100644
--- a/monitor.c
+++ b/monitor.c
@@ -3120,11 +3120,15 @@ static int64_t expr_unary(Monitor *mon)
n = 0;
break;
default:
+ errno = 0;
#if TARGET_PHYS_ADDR_BITS > 32
n = strtoull(pch, &p, 0);
#else
n = strtoul(pch, &p, 0);
#endif
+ if (errno == ERANGE) {
+ expr_error(mon, "number too large");
+ }
if (pch == p) {
expr_error(mon, "invalid char in expression");
}
--
1.7.9.2.384.g4a92a
- [Qemu-devel] [PULL 1.1 0/6]: QMP queue, Luiz Capitulino, 2012/05/08
- [Qemu-devel] [PULL 1/6] wakeup on migration, Luiz Capitulino, 2012/05/08
- [Qemu-devel] [PULL 3/6] runstate: introduce suspended state, Luiz Capitulino, 2012/05/08
- [Qemu-devel] [PULL 2/6] qapi-schema.json: fix RunState enums alphabetical order, Luiz Capitulino, 2012/05/08
- [Qemu-devel] [PULL 4/6] vl: drop is_suspended variable, Luiz Capitulino, 2012/05/08
- [Qemu-devel] [PULL 5/6] hmp: expr_unary(): check for overflow in strtoul()/strtoull(),
Luiz Capitulino <=
- [Qemu-devel] [PULL 6/6] hmp: fix bad value conversion for M type, Luiz Capitulino, 2012/05/08
- Re: [Qemu-devel] [PULL 1.1 0/6]: QMP queue, Anthony Liguori, 2012/05/09