[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] RTL8139 hotplug is broken on windows 2008 sp2.
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH] RTL8139 hotplug is broken on windows 2008 sp2. |
Date: |
Wed, 09 May 2012 22:20:31 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
Am 14.02.2012 04:10, schrieb address@hidden:
> From: Bo Yang <address@hidden>
>
> Windows 2008 sp2 tries to read mac address from phys
> and then write the read value into it. This patch
> is a workaround for the issue.
>
> Signed-off-by: Bo Yang <address@hidden>
> ---
> hw/rtl8139.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
Ping! Who feels responsible for reviewing this?
It would be a candidate for 1.1 and 0.15.x (BNC#722643).
Only issue I see is that the subject could be improved (saying what it
does rather than what was broken before, e.g. "rtl8139: Init phys with
MAC address").
Regards,
Andreas
> diff --git a/hw/rtl8139.c b/hw/rtl8139.c
> index 1668390..074a14a 100644
> --- a/hw/rtl8139.c
> +++ b/hw/rtl8139.c
> @@ -3476,6 +3476,8 @@ static int pci_rtl8139_init(PCIDevice *dev)
> s->eeprom.contents[7] = s->conf.macaddr.a[0] | s->conf.macaddr.a[1] << 8;
> s->eeprom.contents[8] = s->conf.macaddr.a[2] | s->conf.macaddr.a[3] << 8;
> s->eeprom.contents[9] = s->conf.macaddr.a[4] | s->conf.macaddr.a[5] << 8;
> + /* workaround broken windows 2008 sp2 driver. */
> + memcpy(s->phys, s->conf.macaddr.a, 6);
>
> s->nic = qemu_new_nic(&net_rtl8139_info, &s->conf,
> object_get_typename(OBJECT(dev)), dev->qdev.id, s);
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH] RTL8139 hotplug is broken on windows 2008 sp2.,
Andreas Färber <=