[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/13] qemu-ga: guest-suspend-disk: don't emit a suc
From: |
Michael Roth |
Subject: |
[Qemu-devel] [PATCH 04/13] qemu-ga: guest-suspend-disk: don't emit a success response |
Date: |
Tue, 15 May 2012 09:48:50 -0500 |
From: Luiz Capitulino <address@hidden>
Today, qemu-ga may not be able to emit a success response when
guest-suspend-disk completes. This happens because the VM may
vanish before qemu-ga is able to emit a response.
This semantic is a bit confusing, as it's not clear for clients if
they should wait for a response or how they should check for success.
This commit solves that problem by changing guest-suspend-disk to
never emit a success response and suggests in the documentation
what clients could do to check for success.
Signed-off-by: Luiz Capitulino <address@hidden>
Signed-off-by: Michael Roth <address@hidden>
---
qapi-schema-guest.json | 16 ++++++++++------
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json
index 1dd3454..88b165c 100644
--- a/qapi-schema-guest.json
+++ b/qapi-schema-guest.json
@@ -363,17 +363,21 @@
# For the best results it's strongly recommended to have the pm-utils
# package installed in the guest.
#
-# Returns: nothing on success
+# This command does NOT return a response on success. There is a high chance
+# the command succeeded if the VM exits with a zero exit status or, when
+# running with --no-shutdown, by issuing the query-status QMP command to
+# to confirm the VM status is "shutdown". However, the VM could also exit
+# (or set its status to "shutdown") due to other reasons.
+#
+# The following errors may be returned:
# If suspend to disk is not supported, Unsupported
#
-# Notes: o This is an asynchronous request. There's no guarantee a response
-# will be sent
-# o It's strongly recommended to issue the guest-sync command before
-# sending commands when the guest resumes
+# Notes: It's strongly recommended to issue the guest-sync command before
+# sending commands when the guest resumes
#
# Since: 1.1
##
-{ 'command': 'guest-suspend-disk' }
+{ 'command': 'guest-suspend-disk', 'success-response': 'no' }
##
# @guest-suspend-ram
--
1.7.4.1
- [Qemu-devel] [PULL] qemu-ga fixes for 1.1, Michael Roth, 2012/05/15
- [Qemu-devel] [PATCH 02/13] qemu-ga: don't warn on no command return, Michael Roth, 2012/05/15
- [Qemu-devel] [PATCH 04/13] qemu-ga: guest-suspend-disk: don't emit a success response,
Michael Roth <=
- [Qemu-devel] [PATCH 01/13] qapi: add support for command options, Michael Roth, 2012/05/15
- [Qemu-devel] [PATCH 03/13] qemu-ga: guest-shutdown: don't emit a success response, Michael Roth, 2012/05/15
- [Qemu-devel] [PATCH 05/13] qemu-ga: guest-suspend-ram: don't emit a success response, Michael Roth, 2012/05/15
- [Qemu-devel] [PATCH 12/13] qemu-ga: fix segv after failure to open log file, Michael Roth, 2012/05/15
- [Qemu-devel] [PATCH 06/13] qemu-ga: guest-suspend-hybrid: don't emit a success response, Michael Roth, 2012/05/15
- [Qemu-devel] [PATCH 11/13] qemu-ga: guest-shutdown: use only async-signal-safe functions, Michael Roth, 2012/05/15
- [Qemu-devel] [PATCH 08/13] qemu-ga: become_daemon(): reopen standard fds to /dev/null, Michael Roth, 2012/05/15
- [Qemu-devel] [PATCH 07/13] qemu-ga: make reopen_fd_to_null() public, Michael Roth, 2012/05/15
- [Qemu-devel] [PATCH 09/13] qemu-ga: guest-suspend: make the API synchronous, Michael Roth, 2012/05/15
- [Qemu-devel] [PATCH 10/13] qemu-ga: guest-shutdown: become synchronous, Michael Roth, 2012/05/15