[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH 2/7] savevm: flush after saving vm state
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [RFC PATCH 2/7] savevm: flush after saving vm state |
Date: |
Fri, 18 May 2012 16:18:27 +0200 |
Writing vm state uses bdrv_pwrite, so it will automatically get flushes
in writethrough mode. But doing a flush at the end in writeback mode
is probably a good idea anyway.
Signed-off-by: Paolo Bonzini <address@hidden>
---
Kind of unrelated, found by inspection.
savevm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/savevm.c b/savevm.c
index 2d18bab..2b6833d 100644
--- a/savevm.c
+++ b/savevm.c
@@ -400,7 +400,7 @@ static int block_get_buffer(void *opaque, uint8_t *buf,
int64_t pos, int size)
static int bdrv_fclose(void *opaque)
{
- return 0;
+ return bdrv_flush(opaque);
}
static QEMUFile *qemu_fopen_bdrv(BlockDriverState *bs, int is_writable)
--
1.7.10.1
- [Qemu-devel] [RFC PATCH 0/7] Manual writethrough cache and cache mode toggle, Paolo Bonzini, 2012/05/18
- [Qemu-devel] [RFC PATCH 2/7] savevm: flush after saving vm state,
Paolo Bonzini <=
- [Qemu-devel] [RFC PATCH 1/7] block: flush in writethrough mode after writes, Paolo Bonzini, 2012/05/18
- [Qemu-devel] [RFC PATCH 3/7] block: do not pass BDRV_O_CACHE_WB to the protocol, Paolo Bonzini, 2012/05/18
- [Qemu-devel] [RFC PATCH 5/7] block: add bdrv_set_enable_write_cache, Paolo Bonzini, 2012/05/18
- [Qemu-devel] [RFC PATCH 4/7] block: copy enable_write_cache in bdrv_append, Paolo Bonzini, 2012/05/18
- [Qemu-devel] [RFC PATCH 6/7] ide: support enable/disable write cache, Paolo Bonzini, 2012/05/18
- [Qemu-devel] [RFC PATCH 7/7] block: do not handle writethrough in qcow2 caches, Paolo Bonzini, 2012/05/18