|
From: | Stefan Weil |
Subject: | Re: [Qemu-devel] [PATCH for-1.1?] slirp: Avoid redefining MAX_TCPOPTLEN |
Date: | Mon, 28 May 2012 09:00:23 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
Am 28.05.2012 08:49, schrieb Paolo Bonzini:
Il 27/05/2012 19:02, Andreas Färber ha scritto:MAX_TCPOPTLEN is being defined as 32. Darwin has it as 40, causing a warning. The value is only used to declare an array, into which currently 4 bytes are written at most. It should therefore be acceptable to adopt the host's definition.
Can we be sure that there will be never a build environment which defines MAX_TCPOPTLENto a value less than 4? If not, either the preprocessor or an assertion should test that, or we could use QEMU_MAX_TCPOPTLEN or SLIRP_MAX_TCPOPTLEN. Regards, Stefan W.
[Prev in Thread] | Current Thread | [Next in Thread] |