[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts |
Date: |
Mon, 28 May 2012 16:14:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
Am 23.05.2012 10:09, schrieb Stefan Hajnoczi:
> On Tue, May 22, 2012 at 10:23 PM, Stefan Weil <address@hidden> wrote:
>> The local variables ret, i are only used if __linux__ is defined.
>>
>> Signed-off-by: Stefan Weil <address@hidden>
>> ---
>> hw/virtio-blk.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> The #ifdef __linux__ further down in the function declares the local
> hdr variable. We could move ret and i down into the #ifdef instead of
> adding a new one.
Sorry, this patch seems to have passed me by: I posted a patch moving
all Linux variables into an #ifdef at the top.
http://patchwork.ozlabs.org/patch/161546/
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts, (continued)
- Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts, Kevin Wolf, 2012/05/23
- Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts, Stefan Weil, 2012/05/23
- Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts, Stefan Hajnoczi, 2012/05/28
- Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts, Daniel P. Berrange, 2012/05/28
- Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts, Peter Maydell, 2012/05/28
- Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts, Anthony Liguori, 2012/05/29
- Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts, Stefan Hajnoczi, 2012/05/30
- Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts, Peter Maydell, 2012/05/30
- Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts, Stefan Hajnoczi, 2012/05/30
- Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts, Kevin Wolf, 2012/05/30
Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts,
Andreas Färber <=