[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/17] qapi: introduce OptsVisitor
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v2 05/17] qapi: introduce OptsVisitor |
Date: |
Wed, 13 Jun 2012 16:03:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120422 Thunderbird/10.0.4 |
On 06/13/12 12:50, Paolo Bonzini wrote:
> Il 13/06/2012 10:22, Laszlo Ersek ha scritto:
>> +static void
>> +opts_type_uint64(Visitor *v, uint64_t *obj, const char *name, Error **errp)
>> +{
>> + OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
>> + const QemuOpt *opt;
>> + const char *str;
>> +
>> + opt = lookup_scalar(ov, name, errp);
>> + if (!opt) {
>> + return;
>> + }
>> +
>> + str = opt->str;
>> + if (str != NULL) {
>> + while (isspace((unsigned char)*str)) {
>> + ++str;
>> + }
>> +
>> + if (*str != '-' && *str != '\0') {
>> + unsigned long long val;
>> + char *endptr;
>> +
>> + /* non-empty, non-negative subject sequence */
>> + errno = 0;
>> + val = strtoull(str, &endptr, 0);
>> + if (*endptr == '\0' && errno == 0 && val <= UINT64_MAX) {
>
> I would have expected a warning from GCC here, but obviously that's not
> the case?
Right, same surprise here. Maybe gcc has seen the light and it realizes
now "long long" can be wider than 64 bits, theoretically.
Thanks for the review!
Laszlo
- [Qemu-devel] [PATCH v2 04/17] expose QemuOpt and QemuOpts struct definitions to interested parties, (continued)
- [Qemu-devel] [PATCH v2 04/17] expose QemuOpt and QemuOpts struct definitions to interested parties, Laszlo Ersek, 2012/06/13
- [Qemu-devel] [PATCH v2 02/17] qapi: generate C types for fixed-width integers, Laszlo Ersek, 2012/06/13
- [Qemu-devel] [PATCH v2 12/17] convert net_init_slirp() to NetClientOptions, Laszlo Ersek, 2012/06/13
- [Qemu-devel] [PATCH v2 10/17] convert net_init_nic() to NetClientOptions, Laszlo Ersek, 2012/06/13
- [Qemu-devel] [PATCH v2 13/17] convert net_init_socket() to NetClientOptions, Laszlo Ersek, 2012/06/13
- [Qemu-devel] [PATCH v2 08/17] hw, net: "net_client_type" -> "NetClientOptionsKind" (qapi-generated), Laszlo Ersek, 2012/06/13
- [Qemu-devel] [PATCH v2 17/17] remove unused QemuOpts parameter from net init functions, Laszlo Ersek, 2012/06/13
- [Qemu-devel] [PATCH v2 05/17] qapi: introduce OptsVisitor, Laszlo Ersek, 2012/06/13
- [Qemu-devel] [PATCH v2 14/17] convert net_init_vde() to NetClientOptions, Laszlo Ersek, 2012/06/13
- [Qemu-devel] [PATCH v2 11/17] convert net_init_dump() to NetClientOptions, Laszlo Ersek, 2012/06/13
- [Qemu-devel] [PATCH v2 15/17] convert net_init_tap() to NetClientOptions, Laszlo Ersek, 2012/06/13
- [Qemu-devel] [PATCH v2 16/17] convert net_init_bridge() to NetClientOptions, Laszlo Ersek, 2012/06/13
- [Qemu-devel] [PATCH v2 09/17] convert net_client_init() to OptsVisitor, Laszlo Ersek, 2012/06/13
- Re: [Qemu-devel] [PATCH v2 00/17] introduce OptsVisitor, rebase -net/-netdev parsing, Paolo Bonzini, 2012/06/13