[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 01/13] unicore32-softmmu: Add unicore32-softmm
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCHv2 01/13] unicore32-softmmu: Add unicore32-softmmu build support |
Date: |
Fri, 15 Jun 2012 14:46:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
Am 15.06.2012 12:28, schrieb Paolo Bonzini:
> Il 15/06/2012 11:47, Guan Xuetao ha scritto:
>> This patch adds unicore32-softmmu build support, include configure,
>> makefile, arch_init, and all missing functions needed by softmmu.
>> Although all missing functions are empty, unicore32-softmmu could
>> be build successfully.
>>
>> Signed-off-by: Guan Xuetao <address@hidden>
>> ---
>> Makefile.target | 2 +
>> arch_init.c | 2 +
>> arch_init.h | 1 +
>> configure | 1 +
>> default-configs/unicore32-softmmu.mak | 1 +
>> target-unicore32/helper.c | 25 +++++++++++----------
>> target-unicore32/machine.c | 23 +++++++++++++++++++
>> target-unicore32/op_helper.c | 24 +++++++++++++++++++-
>> target-unicore32/softmmu.c | 39
>> +++++++++++++++++++++++++++++++++
>> 9 files changed, 105 insertions(+), 13 deletions(-)
>> create mode 100644 default-configs/unicore32-softmmu.mak
>> create mode 100644 target-unicore32/machine.c
>> create mode 100644 target-unicore32/softmmu.c
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index 1582904..7d3b1fd 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -387,6 +387,8 @@ obj-xtensa-y += core-dc232b.o
>> obj-xtensa-y += core-dc233c.o
>> obj-xtensa-y += core-fsf.o
>>
>> +obj-unicore32-y += softmmu.o
>> +
>
> You need to rebase this and put this line (actually
> obj-$(CONFIG_SOFTMMU) += softmmu.o) in target-unicore32/Makefile.objs.
Noticed this, too. I wonder if Xuetao could place the new puv3.c machine
file into hw/unicore32/ now, if he wanted?
The devices now compiled through hw/Makefile.objs should probably remain
in hw/? Or is it acceptable to have "unicore32/puv3.o" in
hw/Makefile.objs with the new build system?
General design question. :)
Andreas
P.S. Please avoid dropping the CCs, the author doesn't seem to be
following qemu-devel too closely and it helps avoid double replies.
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCHv2 00/13] unicore32: add softmmu support and puv3 machine, Guan Xuetao, 2012/06/15
- [Qemu-devel] [PATCHv2 05/13] unicore32-softmmu: Make sure that kernel can access user space, Guan Xuetao, 2012/06/15
- [Qemu-devel] [PATCHv2 09/13] unicore32-softmmu: Add puv3 gpio support, Guan Xuetao, 2012/06/15
- [Qemu-devel] [PATCHv2 10/13] unicore32-softmmu: Add puv3 pm support, Guan Xuetao, 2012/06/15
- [Qemu-devel] [PATCHv2 07/13] unicore32-softmmu: Add puv3 interrupt support, Guan Xuetao, 2012/06/15
- [Qemu-devel] [PATCHv2 13/13] unicore32-softmmu: Add maintainer information for UniCore32 machine, Guan Xuetao, 2012/06/15
- [Qemu-devel] [PATCHv2 11/13] unicore32-softmmu: Add puv3 dma support, Guan Xuetao, 2012/06/15
- [Qemu-devel] [PATCHv2 06/13] unicore32-softmmu: Add puv3 soc/board support, Guan Xuetao, 2012/06/15