[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functi
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions |
Date: |
Fri, 22 Jun 2012 12:28:00 +1000 |
On Thu, 2012-06-21 at 07:55 -0500, Anthony Liguori wrote:
> As long as we scrub the buffers, returning an unhandled error seems okay to
> me.
>
> I've long thought we should have some sort of generic way to throw an error
> and
> effectively pause a single device. I'm not sure how it would work in
> practice
> though.
I'll scrub the buffer in dma_memory_rw when reading from the guest in
all failure cases to ensure that we don't use a buffer of stale qemu
data.
In addition I'm doing a separate patch that I'll post later (needs a bit
more time) that improves OHCI's error handling.
Cheers,
Ben.
- [Qemu-devel] [PATCH 00/13] iommu series, Benjamin Herrenschmidt, 2012/06/19
- [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/19
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Anthony Liguori, 2012/06/20
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/20
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Anthony Liguori, 2012/06/20
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/20
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Michael S. Tsirkin, 2012/06/21
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Anthony Liguori, 2012/06/21
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Michael S. Tsirkin, 2012/06/21
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions,
Benjamin Herrenschmidt <=
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Gerd Hoffmann, 2012/06/21
- [Qemu-devel] [PATCH 05/13] iommu: Make sglists and dma_bdrv helpers use new universal DMA helpers, Benjamin Herrenschmidt, 2012/06/19
- [Qemu-devel] [PATCH 06/13] ide/ahci: Use universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/19
- [Qemu-devel] [PATCH 09/13] iommu: Add facility to cancel in-use dma memory maps, Benjamin Herrenschmidt, 2012/06/19
- [Qemu-devel] [PATCH 08/13] iommu: Introduce IOMMU emulation infrastructure, Benjamin Herrenschmidt, 2012/06/19