Re: [Qemu-devel] [PATCH v2 3/5] qemu-img: avoid excessive BlockFragInfo line length

[Eric Blake]

On 02/06/2013 04:30 AM, Kevin Wolf wrote:

>>  
>> -    if (result.bfi.total_clusters != 0 && result.bfi.allocated_clusters != 
>> 0) {
>> -        printf("%" PRId64 "/%" PRId64 "= %0.2f%% allocated, %0.2f%% 
>> fragmented\n",
>> -        result.bfi.allocated_clusters, result.bfi.total_clusters,
>> -        result.bfi.allocated_clusters * 100.0 / result.bfi.total_clusters,
>> -        result.bfi.fragmented_clusters * 100.0 / 
>> result.bfi.allocated_clusters);
>> +    if (bfi->total_clusters != 0 && bfi->allocated_clusters != 0) {
>> +        printf("%" PRId64 "/%" PRId64 "= %0.2f%% allocated, "
> 
> Can you add a space before the '=' while touching this?

Perhaps he can, but as this is user-visible output, and we don't yet
have a way to force JSON output to get at the same information,
arbitrarily changing the output format may break some existing user that
is scraping the output.  It would be nice if we had access to this
output information in a more stable format.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature