Re: [Qemu-devel] [PATCH 05/10] mips-linux-user: Fix n32 and n64 syscalls

[Peter Maydell]

On 10 February 2013 18:30, Richard Henderson <address@hidden> wrote:
> Signed-off-by: Richard Henderson <address@hidden>

Reviewed-by: Peter Maydell <address@hidden>

> -            if ((unsigned int)ret >= (unsigned int)(-1133)) {
> +            if ((abi_ulong)ret >= (abi_ulong)-1133) {
>                  env->active_tc.gpr[7] = 1; /* error flag */
>                  ret = -ret;
>              } else {

You're only changing the cast here, so this isn't something you
should feel the need to fix in this patch, but do you know what's
special about -1133 ?

-- PMM