[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RESEND for 1.4-stable] net: reduce memory alloca
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH RESEND for 1.4-stable] net: reduce memory allocation when multiqueue is not used |
Date: |
Thu, 21 Feb 2013 13:23:27 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 |
On 02/20/2013 09:01 PM, Stefan Hajnoczi wrote:
> On Wed, Feb 20, 2013 at 06:11:33PM +0800, Jason Wang wrote:
>> Edivaldo reports a problem that the array of NetClientState in NICState is
>> too
>> large - MAX_QUEUE_NUM(1024) which will waste memory even if multiqueue is not
>> used.
>>
>> For 1.4 we can just solve this by reduce the MAX_QUEUE_NUM to 8 which is the
>> same as the current kernel (3.8+) tap queue limit. For 1.5, we will use
>> dynamic
>> allocation instead.
>>
>> Cc: Edivaldo de Araujo Pereira <address@hidden>
>> Signed-off-by: Jason Wang <address@hidden>
>> ---
>> RESEND since the previous mail misses the list.
>> ---
>> include/net/net.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
> Is dynamic allocation much more complex? If it takes another 2 or 3
> days to come up with a patch, then that would be preferrable to a static
> 8 queue limit.
>
> Stefan
>
Should be not complex, will do it.
Thanks