[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC][PATCH] iscsi: retry read, write, flush and unmap
From: |
Peter Lieven |
Subject: |
Re: [Qemu-devel] [RFC][PATCH] iscsi: retry read, write, flush and unmap on unit attention check conditions |
Date: |
Thu, 21 Feb 2013 15:24:48 +0100 |
Am 18.02.2013 um 17:14 schrieb Paolo Bonzini <address@hidden>:
> Il 18/02/2013 16:58, Peter Lieven ha scritto:
>>
>> + acb = qemu_aio_get(&iscsi_aiocb_info, bs, cb, opaque);
>> +
>> + acb->iscsilun = iscsilun;
>> + acb->retries = ISCSI_CMD_RETRIES;
>> + acb->nb_sectors = nb_sectors;
>> + acb->sector_num = sector_num;
>> + acb->retries = ISCSI_CMD_RETRIES;
>
> Looks good apart from the duplication here. I can fix that up when
> committing.
Hi Paolo,
if the volume is thin-provisioned my storage sends also other attention codes.
I will fix the read capacity code to also accept up to ISCSI_CMD_RETRIES
check conditions and send a new patch shortly.
Peter
>
> Paolo