Re: [Qemu-devel] [RFC PATCH RDMA support v5: 01/12] ./configure with and without --enable-rdma

[Paolo Bonzini]

Il 09/04/2013 05:04, address@hidden ha scritto:
> +if test "$rdma" = "yes" ; then
> +  cat > $TMPC <<EOF
> +#include <rdma/rdma_cma.h>
> +int main(void) { return 0; }
> +EOF
> +  rdma_libs="-lrdmacm -libverbs"
> +  if ! compile_prog "" "$rdma_libs" ; then
> +      feature_not_found "rdma"
> +  fi
> +    

Please enable this by default, or it will bitrot.

The test should be like this:

if test "$rdma" != "no" ; then
  cat > $TMPC << EOF
...
EOF
  rdma_libs="-lrdmacm -libverbs"
  if compile_prog "-Werror" "$rdma_libs" ; then
    rdma="yes"
    libs_softmmu="$libs_softmmu $rdma_libs"
  else
    if test "$rdma" = "yes" ; then
      feature_not_found "rdma"
    fi
    rdma="no"
  fi
fi


...

if test "$rdma" = "yes" ; then
  echo "CONFIG_RDMA=y" >> $config_host_mak
fi