[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/16] qemu-io: Split off commands to qemu-io-cm
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 06/16] qemu-io: Split off commands to qemu-io-cmds.c |
Date: |
Tue, 4 Jun 2013 12:11:47 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 29.05.2013 um 22:29 hat Eric Blake geschrieben:
> On 05/28/2013 09:27 AM, Kevin Wolf wrote:
> > This is the implementation of all qemu-io commands that make sense to be
> > called from the qemu monitor, i.e. everything except open, close and
> > quit.
> >
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > Makefile | 2 +-
> > qemu-io-cmds.c | 1835
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > qemu-io.c | 1817
> > +------------------------------------------------------
> > 3 files changed, 1838 insertions(+), 1816 deletions(-)
> > create mode 100644 qemu-io-cmds.c
>
> I checked the bulk of this patch via:
>
> $ diff -u <(sed -n '/^-/ s///p' file) <(sed -n '/^\+/ s///p' file)
>
> The bulk of the patch is blind code motion plus a bit of touchup; I did
> however spot one case where you were too eager in your search-and-replace:
>
> * Memory allocation helpers.
> *
> - * Make sure memory is aligned by default, or purposefully misaligned if
> + * Make sure memory is aligned by default, or purposefully
> qemuio_misaligned if
> * that is specified on the command line.
Whoops, thanks for spotting this. :-)
> > +
> > +int qemuio_misalign;
>
> Should this variable be typed 'bool'?
It should, but this is merely code motion, so I won't fix it here.
Kevin
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 06/16] qemu-io: Split off commands to qemu-io-cmds.c,
Kevin Wolf <=