[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 20/26] ide: Set BSY bit during FLUSH
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 20/26] ide: Set BSY bit during FLUSH |
Date: |
Fri, 07 Jun 2013 08:10:39 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 07/06/2013 07:58, Stefan Hajnoczi ha scritto:
> From: Andreas Färber <address@hidden>
>
> The implementation of the ATA FLUSH command invokes a flush at the block
> layer, which may on raw files on POSIX entail a synchronous fdatasync().
> This may in some cases take so long that the SLES 11 SP1 guest driver
> reports I/O errors and filesystems get corrupted or remounted read-only.
>
> Avoid this by setting BUSY_STAT, so that the guest is made aware we are
> in the middle of an operation and no ATA commands are attempted to be
> processed concurrently.
>
> Addresses BNC#637297.
>
> Suggested-by: Gonglei (Arei) <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> hw/ide/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ide/core.c b/hw/ide/core.c
> index c7a8041..9926d92 100644
> --- a/hw/ide/core.c
> +++ b/hw/ide/core.c
> @@ -814,6 +814,7 @@ void ide_flush_cache(IDEState *s)
> return;
> }
>
> + s->status |= BUSY_STAT;
> bdrv_acct_start(s->bs, &s->acct, 0, BDRV_ACCT_FLUSH);
> bdrv_aio_flush(s->bs, ide_flush_cb, s);
> }
>
Cc: address@hidden
- [Qemu-devel] [PULL 16/26] qemu-io: Use the qemu version for -V, (continued)
- [Qemu-devel] [PULL 16/26] qemu-io: Use the qemu version for -V, Stefan Hajnoczi, 2013/06/07
- [Qemu-devel] [PULL 17/26] Make qemu-io commands available in HMP, Stefan Hajnoczi, 2013/06/07
- [Qemu-devel] [PULL 18/26] blkdebug: Add BLKDBG_FLUSH_TO_OS/DISK events, Stefan Hajnoczi, 2013/06/07
- [Qemu-devel] [PULL 19/26] ide-test: Add enum value for DEV, Stefan Hajnoczi, 2013/06/07
- [Qemu-devel] [PULL 21/26] ide-test: Add FLUSH CACHE test case, Stefan Hajnoczi, 2013/06/07
[Qemu-devel] [PULL 20/26] ide: Set BSY bit during FLUSH, Stefan Hajnoczi, 2013/06/07
- Re: [Qemu-devel] [PULL 20/26] ide: Set BSY bit during FLUSH,
Paolo Bonzini <=
[Qemu-devel] [PULL 22/26] block: add snapshot info query function bdrv_query_snapshot_info_list(), Stefan Hajnoczi, 2013/06/07
[Qemu-devel] [PULL 23/26] block: add image info query function bdrv_query_image_info(), Stefan Hajnoczi, 2013/06/07
[Qemu-devel] [PULL 24/26] qmp: add ImageInfo in BlockDeviceInfo used by query-block, Stefan Hajnoczi, 2013/06/07
[Qemu-devel] [PULL 25/26] hmp: show ImageInfo in 'info block', Stefan Hajnoczi, 2013/06/07
[Qemu-devel] [PULL 26/26] hmp: add parameters device and -v for info block, Stefan Hajnoczi, 2013/06/07
Re: [Qemu-devel] [PULL 00/26] Block patches, Anthony Liguori, 2013/06/17