[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 0/3] Serial cleanup
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v1 0/3] Serial cleanup |
Date: |
Mon, 10 Jun 2013 13:49:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 |
Am 10.06.2013 12:23, schrieb Peter Crosthwaite:
> Ping!
>
> Any objections to this one going in? perhaps even via trivial queue?
No strong objection, but you are using an unusual 12-char indentation in
some places that you may want to check.
Otherwise the cosmetic cleanup looks fine to me.
Cheers,
Andreas
> On Mon, Jun 3, 2013 at 3:11 PM, <address@hidden> wrote:
>> From: Peter Crosthwaite <address@hidden>
>>
>> Some cosmetics, refactored to use util/fifo8 for the FIFO8, then
>> factored out some common code.
>>
>> Tested as working on petalogix-ml605 machine model + Linux (has
>> coverage of serial fifo usage).
>>
>>
>> Peter Crosthwaite (3):
>> char/serial: cosmetic fixes.
>> char/serial: Use generic Fifo8
>> char/serial: serial_ioport_write: Factor out common code
>>
>> hw/char/serial.c | 128
>> +++++++++++++++++++----------------------------
>> include/hw/char/serial.h | 15 ++----
>> 2 files changed, 56 insertions(+), 87 deletions(-)
>>
>> --
>> 1.8.3.rc1.44.gb387c77.dirty
>>
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg