[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-cpu v4 12/18] cpu: Change default for CPUCla
From: |
Jens Freimann |
Subject: |
Re: [Qemu-devel] [PATCH qom-cpu v4 12/18] cpu: Change default for CPUClass::get_paging_enabled() |
Date: |
Tue, 11 Jun 2013 11:00:43 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Jun 09, 2013 at 06:10:41PM +0200, Andreas Färber wrote:
> qemu_get_guest_memory_mapping() uses cpu_paging_enabled() to determine
> whether to use cpu_get_memory_mapping() to return mappings or whether to
> fall back to a simple identity map.
>
> Since by default CPUClass::get_memory_mapping() is not implemented,
> change the default to false to use the identity map by default.
>
> Signed-off-by: Andreas Färber <address@hidden>
Reviewed-by: Jens Freimann <address@hidden>
> ---
> qom/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qom/cpu.c b/qom/cpu.c
> index b25fbc9..dba4a11 100644
> --- a/qom/cpu.c
> +++ b/qom/cpu.c
> @@ -59,7 +59,7 @@ bool cpu_paging_enabled(const CPUState *cpu)
>
> static bool cpu_common_get_paging_enabled(const CPUState *cpu)
> {
> - return true;
> + return false;
> }
>
> void cpu_get_memory_mapping(CPUState *cpu, MemoryMappingList *list,
> --
> 1.8.1.4
>
>
- [Qemu-devel] [PATCH qom-cpu v4 10/18] memory_mapping: Drop qemu_get_memory_mapping() stub, (continued)
- [Qemu-devel] [PATCH qom-cpu v4 10/18] memory_mapping: Drop qemu_get_memory_mapping() stub, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 11/18] dump: Drop qmp_dump_guest_memory() stub and build for all targets, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 09/18] cpu: Turn cpu_get_memory_mapping() into a CPUState hook, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 14/18] dump: Abstract dump_init() with cpu_synchronize_all_states(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 12/18] cpu: Change default for CPUClass::get_paging_enabled(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 13/18] memory_mapping: Cleanup qemu_get_guest_memory_mapping(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 15/18] dump: Abstract dump_init() further with qemu_for_each_cpu(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 16/18] dump: Abstract write_elf{64, 32}_notes() with qemu_for_each_cpu(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 17/18] memory_mapping: Use hwaddr type for MemoryMapping virt_addr field, Andreas Färber, 2013/06/09