[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 7/8] exec: Don't abort when we can't allocat
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH RFC 7/8] exec: Don't abort when we can't allocate guest memory |
Date: |
Thu, 13 Jun 2013 10:33:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 |
Am 13.06.2013 09:02, schrieb Markus Armbruster:
> We abort() on memory allocation failure. abort() is appropriate for
> programming errors. Maybe most memory allocation failures are
> programming errors, maybe not. But guest memory allocation failure
> isn't, and aborting when the user asks for more memory than we can
> provide is not nice. exit(1) instead, and do it in just one place, so
> the error message is consistent.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Acked-by: Andreas Färber <address@hidden>
Thanks for looking into this!
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH RFC 3/8] exec: Reduce ifdeffery around -mem-path, (continued)
- [Qemu-devel] [PATCH RFC 3/8] exec: Reduce ifdeffery around -mem-path, Markus Armbruster, 2013/06/13
- [Qemu-devel] [PATCH RFC 6/8] exec: Clean up unnecessary S390 ifdeffery, Markus Armbruster, 2013/06/13
- [Qemu-devel] [PATCH RFC 1/8] exec: Fix Xen RAM allocation with unusual options, Markus Armbruster, 2013/06/13
- [Qemu-devel] [PATCH RFC 4/8] s390: Simplify the RAM allocation hook, Markus Armbruster, 2013/06/13
- [Qemu-devel] [PATCH RFC 8/8] pc_sysfw: Fix ISA BIOS init for ridiculously big flash, Markus Armbruster, 2013/06/13
- [Qemu-devel] [PATCH RFC 7/8] exec: Don't abort when we can't allocate guest memory, Markus Armbruster, 2013/06/13
- [Qemu-devel] [PATCH RFC 5/8] s390: Make qemu_ram_remap() consistent with allocation, Markus Armbruster, 2013/06/13
- Re: [Qemu-devel] [PATCH RFC 0/8] Guest memory allocation fixes & cleanup, Markus Armbruster, 2013/06/13