Re: [Qemu-devel] [PATCH] qemu-ga: build it even if !system

[Michael Tokarev]

31.07.2013 14:24, Michael Tokarev wrote:
> Move qemu-ga build check out of if softmmu.. into if tools section.
> We want to build qemu-ga for _guest_ even if system build isn't
> done.  It is controlled separately using --enable-guest-agent.

Actually the more I think about it... Maybe it shouldn't depend
on --enable-tools either, but should be an independent option.
Because it isn't really a tool.

The initial issue is - hopefully - clear.  Some obscure guest
which however supports virtio - it needs a guest agent, even
if qemu-system does not build on it.  Example is s390 (not s390x).

/mjt

> Signed-off-by: Michael Tokarev <address@hidden>
> ---
>   configure |    8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/configure b/configure
> index f0761ea..0105fd2 100755
> --- a/configure
> +++ b/configure
> @@ -3430,6 +3430,9 @@ if test "$want_tools" = "yes" ; then
>     tools="qemu-img\$(EXESUF) qemu-io\$(EXESUF) $tools"
>     if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" ] ; then
>       tools="qemu-nbd\$(EXESUF) $tools"
> +    if [ "$guest_agent" = "yes" ]; then
> +      tools="qemu-ga\$(EXESUF) $tools"
> +    fi
>     fi
>   fi
>   if test "$softmmu" = yes ; then
> @@ -3444,11 +3447,6 @@ if test "$softmmu" = yes ; then
>         virtfs=no
>       fi
>     fi
> -  if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" ] ; then
> -    if [ "$guest_agent" = "yes" ]; then
> -      tools="qemu-ga\$(EXESUF) $tools"
> -    fi
> -  fi
>   fi
>
>   # Mac OS X ships with a broken assembler